bitwarden / mobile

Retired Bitwarden mobile app for iOS and Android (MAUI/Xamarin).
https://bitwarden.com
GNU General Public License v3.0
152 stars 24 forks source link

[PM-13356] Fix iOS build by pinning dotnet and MAUI version #3410

Closed vvolkgang closed 1 month ago

vvolkgang commented 1 month ago

Type of change

Objective

iOS build was failing due to installing the latest MAUI version which depends on iOS 18, while using a dotnet version that doesn't support iOS 18. Pinned both dotnet sdk runtime and maui workload versions to the last that supports iOS 17.5.

Tried pinning them to the versions that we were using for the last release but (1) they weren't installing due to a bug in the dotnet version we were using and (2) it's possible that the MAUI version we had isn't available anymore.

Code changes

global.json: Pins the dotnet sdk runtime version. In build.yml, the repo checkout step had to be moved up for this file to be used build.yml:

Before you submit

vvolkgang commented 1 month ago

Build with the latest changes: https://github.com/bitwarden/mobile/actions/runs/11262307839