bitwarden / mobile

Retired Bitwarden mobile app for iOS and Android (MAUI/Xamarin).
https://bitwarden.com
GNU General Public License v3.0
84 stars 11 forks source link

Bitwarden auto-fill service only reconize org.lineageos.jelly as url #364

Closed znEnpsIv9dqzEwMqGLCNbEPafrizTv6MoYrzt93 closed 3 years ago

znEnpsIv9dqzEwMqGLCNbEPafrizTv6MoYrzt93 commented 6 years ago

Enough said on the title.

znEnpsIv9dqzEwMqGLCNbEPafrizTv6MoYrzt93 commented 6 years ago

OS: Linageos 8.1 Selinux : enforced Lineageos version : 15.1-20180821-NIGHLY-oneplus2

AgjHJ9uk34j7rQjYGj177HLhoxrmPCVAQukbmSS commented 3 years ago

Same here 👍

AgjHJ9uk34j7rQjYGj177HLhoxrmPCVAQukbmSS commented 3 years ago

i think something like

diff --git a/src/Android/Accessibility/AccessibilityHelpers.cs b/src/Android/Accessibility/AccessibilityHelpers.cs
index 62dbde81..2b5e280f 100644
--- a/src/Android/Accessibility/AccessibilityHelpers.cs
+++ b/src/Android/Accessibility/AccessibilityHelpers.cs
@@ -83,6 +83,7 @@ namespace Bit.Droid.Accessibility
             new Browser("org.chromium.chrome", "url_bar"),
             new Browser("org.codeaurora.swe.browser", "url_bar"),
             new Browser("org.gnu.icecat", "url_bar_title,mozac_browser_toolbar_url_view"), // 2nd = Anticipation
+            new Browser("org.lineageos.jelly", "url_bar"),
             new Browser("org.mozilla.fenix", "mozac_browser_toolbar_url_view"),
             new Browser("org.mozilla.fenix.nightly", "mozac_browser_toolbar_url_view"), // [DEPRECATED ENTRY]
             new Browser("org.mozilla.fennec_aurora", "mozac_browser_toolbar_url_view,url_bar_title"), // [DEPRECATED ENTRY]
diff --git a/src/Android/Autofill/AutofillHelpers.cs b/src/Android/Autofill/AutofillHelpers.cs
index 127d93ac..40dff335 100644
--- a/src/Android/Autofill/AutofillHelpers.cs
+++ b/src/Android/Autofill/AutofillHelpers.cs
@@ -98,6 +98,7 @@ namespace Bit.Droid.Autofill
             "org.chromium.chrome",
             "org.codeaurora.swe.browser",
             "org.gnu.icecat",
+            "org.lineageos.jelly",
             "org.mozilla.fenix",
             "org.mozilla.fenix.nightly",
             "org.mozilla.fennec_aurora",
diff --git a/src/Android/Resources/xml/autofillservice.xml b/src/Android/Resources/xml/autofillservice.xml
index a808b99e..2f818028 100644
--- a/src/Android/Resources/xml/autofillservice.xml
+++ b/src/Android/Resources/xml/autofillservice.xml
@@ -161,6 +161,9 @@
   <compatibility-package
     android:name="org.gnu.icecat"
     android:maxLongVersionCode="10000000000"/>
+  <compatibility-package
+    android:name="org.lineageos.jelly"
+    android:maxLongVersionCode="10000000000"/>
   <compatibility-package
     android:name="org.mozilla.fenix"
     android:maxLongVersionCode="10000000000"/>

may do it, but I have no way to check if the url_bar part is correct

to try test it, I setup a windows VM with visual studio and xamarin, successfully built and signed an apk but when installing and opening it hangs on the bitwarden logo splash screen

and ideas anyone? thanks!

eliykat commented 3 years ago

Thanks for reporting this issue. Autofill problems can affect different sites, apps, or devices, and we’re working on improving this feature. To help us track and analyze affected sites, please lodge a report using the Google Form mentioned in this issue: #1389. Please also direct any discussion or questions to that issue. This issue will now be closed.