bitwarden / mobile

Retired Bitwarden mobile app for iOS and Android (MAUI/Xamarin).
https://bitwarden.com
GNU General Public License v3.0
82 stars 11 forks source link

[Android] Auto-fill doesn't work on Samsung browser Stable and Beta. #895

Closed onIKnh7BQsMiYbEwaT7PFjO9dLTD3pcFKaVyELo closed 4 years ago

onIKnh7BQsMiYbEwaT7PFjO9dLTD3pcFKaVyELo commented 4 years ago

Describe the Bug

Like in topic

Steps To Reproduce

Try to login via auto-fill on Samsung browser.

Expected Result

Bitwarden auto-fill suggest you to fill passwords.

Actual Result

There isn't suggestion to auto-fill login and password

Screenshots or Video

Screenshot_20200510-223101_Samsung Internet

Environment

mpbw2 commented 4 years ago

Samsung released an updated browser beta today which properly allows both the autofill service and our autofill accessibility service to function.

ICYibFV3xIlr4oql7FRt5bff1QocGSpgYme1pag commented 4 years ago

I can't make it work automatic filling

onIKnh7BQsMiYbEwaT7PFjO9dLTD3pcFKaVyELo commented 4 years ago

Autofill also doesn't work for me, I have latest Bitwarden and tried on latest S Browser Beta

mpbw2 commented 4 years ago

Beta version 12.0.1.4 is working with both accessibility and autofill service (though their autofill service values are a bit strange - give the beta more time to cook).

Edit: Forgot to mention this is with the latest Bitwarden beta as well - I apologize if that was the source of the confusion.

device-2020-05-13-090941

ICYibFV3xIlr4oql7FRt5bff1QocGSpgYme1pag commented 4 years ago

Hello thank you for your reply Where can we find the beta versions of Bitwarden and Samsung Internet Browser 12.0.1.4 Do you have any links please? Thank you

ICYibFV3xIlr4oql7FRt5bff1QocGSpgYme1pag commented 4 years ago

It's good it works, THANKS: +1: i found on apk mirror For those who are interested https://www.apkmirror.com/apk/samsung-electronics-co-ltd/samsung-internet-beta/samsung-internet-beta-12-0-1-4-release/

for me it works with Bitwarden 2.3.1 official version, without beta version but with Samsung Internet Browser Beta 12.0.1.4

mpbw2 commented 4 years ago

It's also available on the Play Store as a separate installation:

https://play.google.com/store/apps/details?id=com.sec.android.app.sbrowser.beta

ICYibFV3xIlr4oql7FRt5bff1QocGSpgYme1pag commented 4 years ago

do you have a link for Bitwarden in beta version? I can't find it Thank you

mpbw2 commented 4 years ago

For Bitwarden use the 'join beta' button on our Play Store page and your existing installation will be upgraded.

onIKnh7BQsMiYbEwaT7PFjO9dLTD3pcFKaVyELo commented 4 years ago

Auto fill doesn't works for me Bitwarden app version: 2.3.1 (2413) I am Bitwarden beta tester. Screenshot_20200518-170034_Samsung Internet Beta

onIKnh7BQsMiYbEwaT7PFjO9dLTD3pcFKaVyELo commented 4 years ago

@mportune-bw I also tried v11.1.2.2 but it also doesn't work

mpbw2 commented 4 years ago

@the4anoni It definitely requires the newer v12.x.x.x release, but unfortunately I'm not sure why that isn't even working for you when it works for others (as well as myself). Maybe something else on your device is interfering with autofill and/or accessibility?

onIKnh7BQsMiYbEwaT7PFjO9dLTD3pcFKaVyELo commented 4 years ago

@the4anoni It definitely requires the newer v12.x.x.x release, but unfortunately I'm not sure why that isn't even working for you when it works for others (as well as myself). Maybe something else on your device is interfering with autofill and/or accessibility?

Auto fill works on chrome

mpbw2 commented 4 years ago

Did you check the settings in v12? Settings > Privacy and security > Autofill forms

Frfvw73Lh4B9EpQ0QRyugBvXppRbwSbchRAYHeB commented 4 years ago

Did you check the settings in v12? Settings > Privacy and security > Autofill forms

Tried with this enabled/disabled and still not working on latest beta for both apps. Also tried disabling the options under Usernames and Passwords to see if that made any difference but no luck.

mpbw2 commented 4 years ago

I'm at a loss. I'll keep an eye out for any clues as to why it's not working for you, but for the moment... /shrug

onIKnh7BQsMiYbEwaT7PFjO9dLTD3pcFKaVyELo commented 4 years ago

Did you check the settings in v12? Settings > Privacy and security > Autofill forms

I had enabled this, but auto fill still doesn't work. Samsung Internet 12.0.1.17 beta

tOY8H8316YJJi0uNtZOCoi9M7kqHD67EePv8wdX commented 4 years ago

I have the same problem, autofill doesn`t work in Samsung Internet. Tried enable/disable some options in Setting and still not working.

Autofill works in Edge and Chrome on same device.

Bitwarden Beta 2.3.1 (2413) Samsung Internet Beta 12.0.1.17

onIKnh7BQsMiYbEwaT7PFjO9dLTD3pcFKaVyELo commented 4 years ago

@mportune-bw can you re-open issue?

ICYibFV3xIlr4oql7FRt5bff1QocGSpgYme1pag commented 4 years ago

With me it works Not always 100%, but it works when it wants Some sites are not working well yet, automatic detection is not always reactive

Conditions for it to work

onIKnh7BQsMiYbEwaT7PFjO9dLTD3pcFKaVyELo commented 4 years ago

With me it works Not always 100%, but it works when it wants Some sites are not working well yet, automatic detection is not always reactive

Conditions for it to work

  • install Bitwarden 2.3.1 on PlayStore
  • install Samsung Browser Beta 12.0.1.17 on APK mirror
  • I use Gboard the Google keyboard
  • In Parameters / System / Language and input / Automatic input service: Select Bitwarden
  • Being on Android 10
  • Activate the filling and accessibility options on Bitwarden
  • In the Settings of Samsung Browser, 1 .Settings / Useful functions / Authorized applications / Bitwarden ACTIVE
  1. Parameters / Confidentiality and security / Automatic filling of ACTIVE forms

Can you give one example site on which auto fill works?

onIKnh7BQsMiYbEwaT7PFjO9dLTD3pcFKaVyELo commented 4 years ago

Try this.

  1. Enter the address below in the url text box of the Samsung browser internet://flags/#force-renderer-accessibility
  2. Change WebAccessibility to enable and then restart browser
  3. That could work.
  • Please upgrade Samsung browser and bitwarden to beta.

p.s. Sorry I can't speak English. I wrote it with a translator.

Doesn't work for me, tried on last SBrowser beta and Bitwarden last beta.

onIKnh7BQsMiYbEwaT7PFjO9dLTD3pcFKaVyELo commented 4 years ago

Sbrowser beta 12.0.1.36 and bitwarden 2.4.3, autofill still doesn't work @mportune-bw

W0OTSLHRpjuhn1QBF1FRUHMvnOI1ZKVzXr5NOQi commented 4 years ago

Sbrowser beta 12.0.1.36 and bitwarden 2.4.3, autofill still doesn't work @mportune-bw

Working fine here

W0OTSLHRpjuhn1QBF1FRUHMvnOI1ZKVzXr5NOQi commented 4 years ago

It doesn't work fine. For example google account sign in. I would suggest to implement a keyboard for such cases. https://github.com/bitwarden/mobile-maui/issues/62

onIKnh7BQsMiYbEwaT7PFjO9dLTD3pcFKaVyELo commented 4 years ago

Screenshot_20200613-122453_Samsung Internet Beta Now it works for me :)

W0OTSLHRpjuhn1QBF1FRUHMvnOI1ZKVzXr5NOQi commented 4 years ago

@the4anoni clicking on that fills password not email address.

onIKnh7BQsMiYbEwaT7PFjO9dLTD3pcFKaVyELo commented 4 years ago

@the4anoni clicking on that fills password not email address.

Only on google.com, on github it works ok.

Also on chrome I've noticed this same bug.

Frfvw73Lh4B9EpQ0QRyugBvXppRbwSbchRAYHeB commented 4 years ago

Auto fill seems to finally work now after the most recent Samsung Internet (not beta) update.

R6pEr0xWC7mU0dxoOsFnNsM4FSqUktEvVEQdKVB commented 4 years ago

Auto fill seems to finally work now after the most recent Samsung Internet (not beta) update.

I get the auto-fill option but clicking on it doesn't give me respective login details instead I get this prompt 'there are no items in you vault for com.sec.android.app.sbrowser.beta'.

fbC31gCxR2tgfXxRsASGADJ88wXqCyBNzpzBaMS commented 4 years ago

Auto fill seems to finally work now after the most recent Samsung Internet (not beta) update.

Can you please report back the exact version number ?

fbC31gCxR2tgfXxRsASGADJ88wXqCyBNzpzBaMS commented 4 years ago

I want to make it clear the problem some people face in using the Auto-fill service using the accessibility feature.

Don't try to use Bitwarden with any browsers in Android until and unless it natively surfaces Bitwarden using Android Autofill API. Forcing the browsers to integrate with Bitwarden using accessibility service would be useless. As Bitwarden can only know the application name using accessibility service and not the website URL. In that case, it would offer incorrect choices.

Instead you can use Bitwarden with any apps such as Instagram, or your banking app in Android. As in this case, Bitwarden just needs to know the application name alone.

z2O23z7aygj6gcI7v7d99q9L3uBnH7gd8IJiSgx commented 4 years ago

For me auto fill "works" but it just sees Samsung Browser as an app and won't show me webpage log ins like in chrome.

fbC31gCxR2tgfXxRsASGADJ88wXqCyBNzpzBaMS commented 4 years ago

For me auto fill "works" but it just sees Samsung Browser as an app and won't show me webpage log ins like in chrome.

Please refer my previous comment. I have given a clear explanation.

Ko9EW8O2crx26jOwU0hEpO4grb7OEQMUjdR1Eb9 commented 4 years ago

Any updates on this? As mentioned above, accessibility services is NOT an option for using with this browser. I have moved to opera, untill this get fixed

X8Y0VaT36pq6o9BRth8RRcnKwlE5Q7w9moAsnzI commented 3 years ago

I'm having major issues with the autofill service in Samsung Internet for a long time now. Is there any more information on this @mportune-bw?

Ko9EW8O2crx26jOwU0hEpO4grb7OEQMUjdR1Eb9 commented 3 years ago

I'm having major issues with the autofill service in Samsung Internet for a long time now. Is there any more information on this @mportune-bw?

As far as I understand, Samsung is not too committed to implementing this on their browser, since they rather push users to their own Samsung Pass. But, maybe when they upgrade their chromium base in future builds this might get inherited. I have tried to reach many of Samsung browser's devs on their Twitter and their Blog, and on Samsung forums, about this, but I am always ignored.

X8Y0VaT36pq6o9BRth8RRcnKwlE5Q7w9moAsnzI commented 3 years ago

I'm having major issues with the autofill service in Samsung Internet for a long time now. Is there any more information on this @mportune-bw?

As far as I understand, Samsung is not too committed to implementing this on their browser, since they rather push users to their own Samsung Pass. But, maybe when they upgrade their chromium base in future builds this might get inherited. I have tried to reach many of Samsung browser's devs on their Twitter and their Blog, and on Samsung forums, about this, but I am always ignored.

Damn, that is extremely unfortunate. Hopefully they'll fully embrace the autofill framework to push more users to their browser.

SgOhSPxCn0Oii6IaFXGDxHDC3wiU361nuzrryXF commented 3 years ago

@mportune-bw i found out when it stops working and what to do as a workaround to make it work again. When I go to the tab view in Samsung internet and open a new tab, i go to the login page of that particular website, and bitwarden doesn't work. When I close the samsung internet app and re-open it. It starts loading the login page of that particular website again and voila, bitwarden works.

Test scenario 2: when i open two new tabs with two different websited and go to the login pages of both websites, close samsung internet and reopen the app, then bitwarden works on both tabs. I can switch between the tabs and it remains working. When I close one of the two and the other one remains working until both tabs are closed and obviously to browse you need a new tab.

So, workaround for now is: when I reach a login page, close samsung internet and reopen. Even though this workaround works 100% of the time for me, it has become slightly annoying that I have to keep doing this. Is this a bitwarden or samsung internet app issue?

Versions Bitwarden: Version: 2.9.1 (3444) Samsung Internet: 14.0.1.62

Edit: also raised an issue with samsung regarding samsung internet app. So both parties can have a look at it. It seems to be more of an issue with Samsung Internet app than Bitwarden. As if theres a bug how Samsung Internet allows third party apps to use the auto fill feature. Because Bitwarden works fine on other browser apps (chrome, brave and above confirmed by other users: firefox etc)

SgOhSPxCn0Oii6IaFXGDxHDC3wiU361nuzrryXF commented 3 years ago

@mportune-bw i found out when it stops working and what to do as a workaround to make it work again. When I go to the tab view in Samsung internet and open a new tab, i go to the login page of that particular website, and bitwarden doesn't work. When I close the samsung internet app and re-open it. It starts loading the login page of that particular website again and voila, bitwarden works.

Test scenario 2: when i open two new tabs with two different websited and go to the login pages of both websites, close samsung internet and reopen the app, then bitwarden works on both tabs. I can switch between the tabs and it remains working. When I close one of the two and the other one remains working until both tabs are closed and obviously to browse you need a new tab.

So, workaround for now is: when I reach a login page, close samsung internet and reopen. Even though this workaround works 100% of the time for me, it has become slightly annoying that I have to keep doing this. Is this a bitwarden or samsung internet app issue?

Versions Bitwarden: Version: 2.9.1 (3444) Samsung Internet: 14.0.1.62

Edit: also raised an issue with samsung regarding samsung internet app. So both parties can have a look at it. It seems to be more of an issue with Samsung Internet app than Bitwarden. As if theres a bug how Samsung Internet allows third party apps to use the auto fill feature. Because Bitwarden works fine on other browser apps (chrome, brave and above confirmed by other users: firefox etc)

So response from Samsung is as expected utterly useless!! Or the support agent didn't take the time to really read my error description or lack the knowledge to think and see the bigger picture. Their response was:

Dear Customer,

Thank you for contacting us. We appreciate the opportunity to assist you.

I understand you wish to use third party apps. Since we are not directly afilitated we can offer no assistance in this regard. Samsung will not change the browser for a company they have no partnerships with.

Also know that you might receive a short survey regarding our interaction. Please take a few seconds to it fill out it would greatly help us improve our customer support experience!

I have sent a new inquiry to have them read my problem description again and try to think along. Or is there something you can do without their support @mportune-bw

Ko9EW8O2crx26jOwU0hEpO4grb7OEQMUjdR1Eb9 commented 3 years ago

Try contacting them on Twitter @samsunginternet. Their Browser development team is based in the UK, and seems to be pretty separate from the rest of their development, which takes part mostly in India.

SgOhSPxCn0Oii6IaFXGDxHDC3wiU361nuzrryXF commented 3 years ago

Try contacting them on Twitter @SamsungInternet. Their Browser development team is based in the UK, and seems to be pretty separate from the rest of their development, which takes part mostly in India.

I just sent them an email. Hope we get a better response or at least a point into the right direction if they're convinced its not a samsung internet issue.

mpbw2 commented 3 years ago

Samsung will not change the browser for a company they have no partnerships with.

@Tosko4 This is the only substance in the reply. Awhile back we tested the theory that they were whitelisting 3rd party password managers instead of allowing use of the API across the board. I renamed the Bitwarden package name to match another popular password manager that we know works for sure with Samsung Internet, and viola - Bitwarden worked perfectly. We've made several attempts to contact Samsung to add Bitwarden to the whitelist, but we've never received a response.

SgOhSPxCn0Oii6IaFXGDxHDC3wiU361nuzrryXF commented 3 years ago

Samsung will not change the browser for a company they have no partnerships with.

@Tosko4 This is the only substance in the reply. Awhile back we tested the theory that they were whitelisting 3rd party password managers instead of allowing use of the API across the board. I renamed the Bitwarden package name to match another popular password manager that we know works for sure with Samsung Internet, and viola - Bitwarden worked perfectly. We've made several attempts to contact Samsung to add Bitwarden to the whitelist, but we've never received a response.

@mportune-bw It's weird. If bitwarden is not whitelisted, then it shouldn't work at all right? Maybe a silly question. But it works for me when I close and reopen samsung internet app. So I tend to lean more towards what @yurividal said, the android autofill api compatibility, no?

mpbw2 commented 3 years ago

@Tosko4 It's hard to say for sure. The fact that it sometimes works without the whitelist could just be a bug in their whitelist implementation. I can tell you this much though - we don't receive a single blip from the autofill event stream when using Samsung Internet (without the forged package name). It's like it's not even turned on.

SgOhSPxCn0Oii6IaFXGDxHDC3wiU361nuzrryXF commented 3 years ago

@mportune-bw gotcha, thanks for responding. I have sent an update to samsung, hoping they respond fingers crossed i'll keep you guys posted

Ko9EW8O2crx26jOwU0hEpO4grb7OEQMUjdR1Eb9 commented 3 years ago

The "sometimes" working is probably the legacy "Accessibility" api... We need to make some noise, get our voice heard and hopefully the Samsung Internet team will do something about it...

mpbw2 commented 3 years ago

@yurividal Fwiw we show a different icon for Accessibility (black & white shield, vs blue for Autofill) for exactly this purpose. It was becoming nearly impossible to troubleshoot when users had both enabled and they were visually identical.

sGQqaLaWhv84nhwaz7NOrTtphakmYMRKppQDwP1 commented 3 years ago

Could you give us a "beta" version that has a forged package name until Samsung has finally fixed this?

X8Y0VaT36pq6o9BRth8RRcnKwlE5Q7w9moAsnzI commented 3 years ago

You'd think Samsung would want to gain market share for their mobile browser. 🤔