bitwarden / passwordless-server

Bitwarden Passwordless.dev infrastructure/backend (API, database, Docker, etc).
https://bitwarden.com/
Other
86 stars 28 forks source link

PAS-468 | Use options pattern for magic links and application overrides #613

Closed jonashendrickx closed 5 months ago

jonashendrickx commented 5 months ago

Ticket

Description

The previous implementation was fairly weakly typed. Now using the option pattern.

Shape

This should bring some improvements with request scoped caching to slightly improve performance for magic links and application overrides.

Screenshots

Checklist

I did the following to ensure that my changes were tested thoroughly:

I did the following to ensure that my changes do not introduce security vulnerabilities:

codecov[bot] commented 5 months ago

Codecov Report

Attention: Patch coverage is 70.58824% with 5 lines in your changes missing coverage. Please review.

Project coverage is 33.00%. Comparing base (04440ec) to head (821ee50).

Files Patch % Lines
src/Api/Endpoints/Magic.cs 0.00% 4 Missing :warning:
src/Service/MagicLinks/MagicLinkService.cs 83.33% 0 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #613 +/- ## ======================================= Coverage 33.00% 33.00% ======================================= Files 513 514 +1 Lines 26133 26131 -2 Branches 775 774 -1 ======================================= + Hits 8624 8625 +1 + Misses 17381 17378 -3 Partials 128 128 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.