Closed jonashendrickx closed 5 months ago
Attention: Patch coverage is 70.58824%
with 5 lines
in your changes missing coverage. Please review.
Project coverage is 33.00%. Comparing base (
04440ec
) to head (821ee50
).
Files | Patch % | Lines |
---|---|---|
src/Api/Endpoints/Magic.cs | 0.00% | 4 Missing :warning: |
src/Service/MagicLinks/MagicLinkService.cs | 83.33% | 0 Missing and 1 partial :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Ticket
Description
The previous implementation was fairly weakly typed. Now using the option pattern.
Shape
This should bring some improvements with request scoped caching to slightly improve performance for magic links and application overrides.
Screenshots
Checklist
I did the following to ensure that my changes were tested thoroughly:
I did the following to ensure that my changes do not introduce security vulnerabilities: