search

bitwarden / passwordless-server

Bitwarden Passwordless.dev infrastructure/backend (API, database, Docker, etc).
https://bitwarden.com/
Other
86 stars 28 forks source link

Refactor the logout page #619

Closed jonashendrickx closed 5 months ago

jonashendrickx commented 5 months ago

Description

Refactors the logout page, so we're using the NotAuthorized handler defined in the layout to redirect us to the proper pages upon successfully logging out.

We no longer need to manually redirect to a different/same page showing we have successfully logged out, instead we rely on being redirected to the default page when not authorized, which is the '/account/login' page.

Shape

Screenshots

n/a

Checklist

I did the following to ensure that my changes do not introduce security vulnerabilities:

codecov[bot] commented 5 months ago

Codecov Report

Attention: Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.

Project coverage is 34.13%. Comparing base (07e2f37) to head (21c8f45).

Files Patch % Lines
...AdminConsole/Components/Pages/Account/Logout.razor 0.00% 9 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #619 +/- ## ========================================== + Coverage 34.11% 34.13% +0.01% ========================================== Files 536 534 -2 Lines 27552 27541 -11 Branches 807 806 -1 ========================================== Hits 9400 9400 + Misses 18021 18010 -11 Partials 131 131 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.