bitwarden / passwordless-server

Bitwarden Passwordless.dev infrastructure/backend (API, database, Docker, etc).
https://bitwarden.com/
Other
86 stars 28 forks source link

PAS-516 | Verified indices for ApiKeys, Aliases, Credentials #634

Closed jonashendrickx closed 3 months ago

jonashendrickx commented 4 months ago

Ticket

Description

This pull request covers the indices for the hot code paths such as:

Shape

n/a

Screenshots

n/a

Checklist

I did the following to ensure that my changes were tested thoroughly:

I did the following to ensure that my changes do not introduce security vulnerabilities:

codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 49.36842% with 481 lines in your changes missing coverage. Please review.

Project coverage is 34.62%. Comparing base (b66156e) to head (6df7c77).

Files Patch % Lines
...240709134121_AddIndicesForHotCodePaths.Designer.cs 0.00% 452 Missing :warning:
.../Mssql/20240709134147_AddIndicesForHotCodePaths.cs 52.17% 11 Missing :warning:
...Sqlite/20240709134121_AddIndicesForHotCodePaths.cs 0.00% 9 Missing :warning:
...vice/Migrations/Mssql/MsSqlContextModelSnapshot.cs 0.00% 5 Missing :warning:
...ce/Migrations/Sqlite/SqliteContextModelSnapshot.cs 0.00% 4 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #634 +/- ## ========================================== + Coverage 34.11% 34.62% +0.51% ========================================== Files 534 538 +4 Lines 27555 28502 +947 Branches 807 807 ========================================== + Hits 9401 9870 +469 - Misses 18023 18501 +478 Partials 131 131 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.