bitwarden / passwordless-server

Bitwarden Passwordless.dev infrastructure/backend (API, database, Docker, etc).
https://bitwarden.com/
Other
86 stars 28 forks source link

PAS-47 | Allow admins to disable magic links for all admins belonging to an organization. #637

Closed jonashendrickx closed 3 months ago

jonashendrickx commented 4 months ago

Ticket

Description

This pull request allows an admin to disable or enable magic links for an entire organization.

Shape

Screenshots

image image image

Checklist

I did the following to ensure that my changes were tested thoroughly:

I did the following to ensure that my changes do not introduce security vulnerabilities:

codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 1.98962% with 1133 lines in your changes missing coverage. Please review.

Project coverage is 33.47%. Comparing base (54262a9) to head (98a00af).

Files Patch % Lines
...lowDisablingMagicLinksForOrganizations.Designer.cs 0.00% 501 Missing :warning:
...lowDisablingMagicLinksForOrganizations.Designer.cs 0.00% 488 Missing :warning:
...ngsComponents/DeleteOrganizationComponent.razor.cs 0.00% 33 Missing :warning:
src/AdminConsole/Pages/Account/Login.cshtml.cs 0.00% 23 Missing :warning:
...tion/SettingsComponents/SecurityComponent.razor.cs 0.00% 21 Missing :warning:
...c/AdminConsole/Services/Mail/DefaultMailService.cs 0.00% 14 Missing :warning:
...084408_AllowDisablingMagicLinksForOrganizations.cs 0.00% 11 Missing :warning:
...084433_AllowDisablingMagicLinksForOrganizations.cs 0.00% 11 Missing :warning:
...ations/Mssql/MssqlConsoleDbContextModelSnapshot.cs 0.00% 6 Missing :warning:
...ions/Sqlite/SqliteConsoleDbContextModelSnapshot.cs 0.00% 6 Missing :warning:
... and 8 more
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #637 +/- ## ========================================== - Coverage 34.58% 33.47% -1.11% ========================================== Files 542 551 +9 Lines 28542 29637 +1095 Branches 821 835 +14 ========================================== + Hits 9870 9922 +52 - Misses 18541 19582 +1041 - Partials 131 133 +2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

abergs commented 4 months ago

Holding this to work out the complexity of the PR.