Closed jonashendrickx closed 3 months ago
Attention: Patch coverage is 1.98962%
with 1133 lines
in your changes missing coverage. Please review.
Project coverage is 33.47%. Comparing base (
54262a9
) to head (98a00af
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Holding this to work out the complexity of the PR.
Ticket
Description
This pull request allows an admin to disable or enable magic links for an entire organization.
Shape
Migrated old
/Organization/Settings
to Blazor.Each section in
/Organization/Settings
is isolated in its own Razor/Blazor component.During login, when the user is found, we check its organization whether the magic links flag is enabled, and handle accordingly in the page handler whether to display an error message or continue sending a magic link.
Limitation: If we had an application per organization to hold credentials for admins, it would have been easier to implement, as we can just listen for the response of sending out magic links and display the error message returned.
Screenshots
Checklist
I did the following to ensure that my changes were tested thoroughly:
I did the following to ensure that my changes do not introduce security vulnerabilities: