search

bitwarden / passwordless-server

Bitwarden Passwordless.dev infrastructure/backend (API, database, Docker, etc).
https://bitwarden.com/
Other
86 stars 28 forks source link

PAS-479 | Repair plan section lifecycle when api keys are (un)locked #639

Closed jonashendrickx closed 4 months ago

jonashendrickx commented 4 months ago

Ticket

Description

When API keys or API secrets are locked or unlocked, the plan section fails to initialize and fails to render as a result. This pull request will repair the lifecycle indefinitely as more sections & forms are added to the application settings pages.

Shape

Screenshots

https://github.com/user-attachments/assets/13567947-4a78-4718-921b-8d66e7430a38

Checklist

I did the following to ensure that my changes were tested thoroughly:

I did the following to ensure that my changes do not introduce security vulnerabilities:

codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 0% with 61 lines in your changes missing coverage. Please review.

Project coverage is 34.10%. Comparing base (b66156e) to head (5e5128c).

Files Patch % Lines
.../App/Settings/SettingsComponents/PlanSection.razor 0.00% 52 Missing :warning:
...tings/SettingsComponents/FeatureListItemIcon.razor 0.00% 4 Missing :warning:
src/AdminConsole/Middleware/CurrentContext.cs 0.00% 4 Missing :warning:
...AdminConsole/Pages/App/Settings/Settings.cshtml.cs 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #639 +/- ## ========================================== - Coverage 34.11% 34.10% -0.02% ========================================== Files 534 536 +2 Lines 27555 27564 +9 Branches 807 813 +6 ========================================== Hits 9401 9401 - Misses 18023 18032 +9 Partials 131 131 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.