bitwarden / passwordless-server

Bitwarden Passwordless.dev infrastructure/backend (API, database, Docker, etc).
https://bitwarden.com/
Other
86 stars 28 forks source link

PAS-479 | Refactor application settings #647

Closed jonashendrickx closed 3 months ago

jonashendrickx commented 3 months ago

Ticket

Description

The final pull request to split all sections up in their own component, including migration of the parent page.

Shape

Screenshots

Checklist

I did the following to ensure that my changes were tested thoroughly:

I did the following to ensure that my changes do not introduce security vulnerabilities:

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 16.66667% with 90 lines in your changes missing coverage. Please review.

Project coverage is 34.61%. Comparing base (8212280) to head (ccbf5d8).

Files Patch % Lines
...ttingsComponents/DeleteApplicationSection.razor.cs 0.00% 48 Missing :warning:
...ettings/SettingsComponents/ApiKeysSection.razor.cs 0.00% 11 Missing :warning:
src/AdminConsole/Components/App.razor 0.00% 7 Missing :warning:
...le/Components/Pages/App/Settings/Settings.razor.cs 0.00% 6 Missing :warning:
...ings/SettingsComponents/MagicLinksSection.razor.cs 0.00% 5 Missing :warning:
...uallyGeneratedAuthenticationTokensSection.razor.cs 0.00% 5 Missing :warning:
...e/Components/Shared/SecureImportMapScript.razor.cs 78.57% 1 Missing and 2 partials :warning:
...nsole/Components/Pages/App/Settings/Settings.razor 0.00% 2 Missing :warning:
.../SettingsComponents/DeleteApplicationSection.razor 0.00% 2 Missing :warning:
.../App/Settings/SettingsComponents/PlanSection.razor 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #647 +/- ## ========================================== + Coverage 34.58% 34.61% +0.03% ========================================== Files 542 547 +5 Lines 28542 28547 +5 Branches 821 820 -1 ========================================== + Hits 9870 9881 +11 + Misses 18541 18536 -5 + Partials 131 130 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.