search

bitwarden / passwordless-server

Bitwarden Passwordless.dev infrastructure/backend (API, database, Docker, etc).
https://bitwarden.com/
Other
83 stars 26 forks source link

PAS-540 | Parameters were being incorrectly passed #650

Closed jonashendrickx closed 2 months ago

jonashendrickx commented 2 months ago

Ticket

Description

E-mails were not being sent when magic links were disabled because the parameters were not correctly mapped. This wasn't caught by the FileMailProvider.

Shape

Screenshots

Checklist

I did the following to ensure that my changes were tested thoroughly:

I did the following to ensure that my changes do not introduce security vulnerabilities:

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 92.64706% with 20 lines in your changes missing coverage. Please review.

Project coverage is 34.12%. Comparing base (bd1f110) to head (9d31f4c). Report is 1 commits behind head on main.

Files Patch % Lines
src/Common/Validation/EmailValidator.cs 96.59% 4 Missing and 4 partials :warning:
...c/AdminConsole/Services/Mail/DefaultMailService.cs 50.00% 5 Missing :warning:
src/Common/Validation/EmailValidationError.cs 75.00% 3 Missing :warning:
src/Common/Validation/EmailAttribute.cs 81.81% 1 Missing and 1 partial :warning:
src/AdminConsole/Pages/Account/Login.cshtml.cs 0.00% 1 Missing :warning:
src/AdminConsole/Program.cs 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #650 +/- ## ========================================== + Coverage 33.50% 34.12% +0.61% ========================================== Files 556 560 +4 Lines 29642 29905 +263 Branches 834 918 +84 ========================================== + Hits 9933 10204 +271 + Misses 19577 19564 -13 - Partials 132 137 +5 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.