search

bitwarden / passwordless-server

Bitwarden Passwordless.dev infrastructure/backend (API, database, Docker, etc).
https://bitwarden.com/
Other
83 stars 26 forks source link

PAS-541 | Disable feature to disable magic links for organizations #660

Closed jonashendrickx closed 1 month ago

jonashendrickx commented 1 month ago

Ticket

Description

This pull request disables the feature to disable magic links for organizations by default.

Shape

Screenshots

Checklist

I did the following to ensure that my changes were tested thoroughly:

I did the following to ensure that my changes do not introduce security vulnerabilities:

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 46.42857% with 15 lines in your changes missing coverage. Please review.

Project coverage is 34.88%. Comparing base (c2d02cf) to head (43dcc15).

Files Patch % Lines
...minConsole/Services/MagicLinks/MagicLinkBuilder.cs 0.00% 5 Missing :warning:
...dminConsole/Middleware/CurrentContextMiddleware.cs 0.00% 3 Missing :warning:
...omponents/Pages/App/Settings/CreatePublicKey.razor 0.00% 2 Missing :warning:
...omponents/Pages/App/Settings/CreateSecretKey.razor 0.00% 2 Missing :warning:
src/AdminConsole/Program.cs 0.00% 2 Missing :warning:
...ole/Pages/Organization/CreateApplication.cshtml.cs 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #660 +/- ## ========================================== + Coverage 34.84% 34.88% +0.04% ========================================== Files 565 566 +1 Lines 30901 30916 +15 Branches 922 920 -2 ========================================== + Hits 10768 10786 +18 + Misses 19990 19988 -2 + Partials 143 142 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.