bitwarden / passwordless-server

Bitwarden Passwordless.dev infrastructure/backend (API, database, Docker, etc).
https://bitwarden.com/
Other
86 stars 28 forks source link

PAS-559 | Authorization handler is being executed concurrently. #673

Closed jonashendrickx closed 3 months ago

jonashendrickx commented 3 months ago

Ticket

Description

  1. We will need IDbContextFactory, this won't fix it permanently. Authorization handlers can be executed concurrently when Blazor/Razor components are being rendered.
  2. Adds the alias route '/signup' back for '/organization/create'

Shape

n/a

Screenshots

Checklist

I did the following to ensure that my changes were tested thoroughly:

I did the following to ensure that my changes do not introduce security vulnerabilities:

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 12.00000% with 22 lines in your changes missing coverage. Please review.

Project coverage is 34.83%. Comparing base (4d08754) to head (b622961). Report is 1 commits behind head on main.

Files Patch % Lines
src/AdminConsole/Authorization/HasAppHandler.cs 0.00% 8 Missing :warning:
...dminConsole/Middleware/CurrentContextMiddleware.cs 0.00% 6 Missing :warning:
src/AdminConsole/Services/DataService.cs 0.00% 6 Missing :warning:
src/AdminConsole/Program.cs 0.00% 1 Missing :warning:
...dminConsole/Services/OrganizationFeatureService.cs 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #673 +/- ## ========================================== - Coverage 34.85% 34.83% -0.02% ========================================== Files 565 565 Lines 30945 30961 +16 Branches 923 924 +1 ========================================== + Hits 10785 10786 +1 - Misses 20018 20033 +15 Partials 142 142 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.