bitwarden / passwordless-server

Bitwarden Passwordless.dev infrastructure/backend (API, database, Docker, etc).
https://bitwarden.com/
Other
86 stars 28 forks source link

Wait Strategy needs to be changed for TestContainers #692

Closed jonashendrickx closed 2 months ago

jonashendrickx commented 2 months ago

Description

After upgrading to Docker 4.33, I cannot get the integration tests to work on either Windows or Mac OS. This appears to work on both. There are some posts mentioning that the way we need to check for a ready SQL Server container has changed recently:

Confirmed to work on:

Not working on:

Shape

Screenshots

Checklist

I did the following to ensure that my changes were tested thoroughly:

I did the following to ensure that my changes do not introduce security vulnerabilities:

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 34.89%. Comparing base (74ed3d6) to head (b4ff02b). Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #692 +/- ## ======================================= Coverage 34.89% 34.89% ======================================= Files 566 566 Lines 31007 31007 Branches 936 936 ======================================= Hits 10819 10819 Misses 20043 20043 Partials 145 145 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.