search

bitwarden / passwordless-server

Bitwarden Passwordless.dev infrastructure/backend (API, database, Docker, etc).
https://bitwarden.com/
Other
86 stars 28 forks source link

Migrate magic link page #697

Closed jonashendrickx closed 2 months ago

jonashendrickx commented 2 months ago

Description

Migrated the magic links page at /account/magic. Still cannot seem to figure out how to mock the query parameters. Have tried using cascading parameters, which doesn't appear to work. Using FakeNavigationManager didn't work either.

Shape

Screenshots

Checklist

I did the following to ensure that my changes were tested thoroughly:

I did the following to ensure that my changes do not introduce security vulnerabilities:

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 35.71429% with 9 lines in your changes missing coverage. Please review.

Project coverage is 34.91%. Comparing base (bc4d39a) to head (be3f3f0). Report is 3 commits behind head on main.

Files Patch % Lines
...minConsole/Components/Pages/Account/Magic.razor.cs 30.76% 8 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #697 +/- ## ========================================== + Coverage 34.88% 34.91% +0.02% ========================================== Files 567 567 Lines 31010 31005 -5 Branches 936 934 -2 ========================================== + Hits 10818 10824 +6 + Misses 20046 20034 -12 - Partials 146 147 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.