bitwarden / passwordless-server

Bitwarden Passwordless.dev infrastructure/backend (API, database, Docker, etc).
https://bitwarden.com/
Other
86 stars 28 forks source link

PAS-561: Verify input with the SupplyFromQueryParameterAttribute #698

Closed jonashendrickx closed 2 months ago

jonashendrickx commented 2 months ago

Ticket

Description

Wasn't able to unit test pages before when a SupplyFromQueryParameterAttribute was being used. The functionality was apparently available in a newer bunit version. But we couldn't upgrade unless we also upgraded HtmlAgililtyPack.

There does not seem to be any impact from using a prerelease version of HtmlAgilityPack as its unit tests are still passing as expected.

This pull request will finally allow us to unit test all the bits in the admin console to validate any conditional rendering that may happen.

Shape

Screenshots

Checklist

I did the following to ensure that my changes were tested thoroughly:

I did the following to ensure that my changes do not introduce security vulnerabilities:

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 35.11%. Comparing base (f664752) to head (f64e5f3). Report is 4 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #698 +/- ## ========================================== + Coverage 35.08% 35.11% +0.02% ========================================== Files 568 568 Lines 31053 31053 Branches 938 938 ========================================== + Hits 10894 10903 +9 + Misses 20010 20002 -8 + Partials 149 148 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.