search

bitwarden / passwordless-server

Bitwarden Passwordless.dev infrastructure/backend (API, database, Docker, etc).
https://bitwarden.com/
Other
86 stars 28 forks source link

PAS-562 | Get rid of `InternalApiUrl`. #702

Closed jonashendrickx closed 2 months ago

jonashendrickx commented 2 months ago

Ticket

Description

The InternalApiUrl gives us too much problems. PAS-386 allows us to hot reload the configuration during the initialization/setup process, which makes it a bit more user friendly to set up Passwordless.dev in a self-hosted environment.

Shape

Screenshots

Checklist

I did the following to ensure that my changes were tested thoroughly:

I did the following to ensure that my changes do not introduce security vulnerabilities:

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 35.12%. Comparing base (f664752) to head (f341a41). Report is 3 commits behind head on main.

Files Patch % Lines
src/AdminConsole/Components/Pages/Initialize.razor 0.00% 1 Missing :warning:
src/AdminConsole/Program.cs 0.00% 1 Missing :warning:
...dlessManagement/PasswordlessManagementBootstrap.cs 0.00% 1 Missing :warning:
.../AdminConsole/Services/ScopedPasswordlessClient.cs 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #702 +/- ## ========================================== + Coverage 35.08% 35.12% +0.04% ========================================== Files 568 568 Lines 31053 31015 -38 Branches 938 931 -7 ========================================== Hits 10894 10894 + Misses 20010 19972 -38 Partials 149 149 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.