search

bitwarden / passwordless-server

Bitwarden Passwordless.dev infrastructure/backend (API, database, Docker, etc).
https://bitwarden.com/
Other
86 stars 28 forks source link

Do not override sender for SMTP configuration #705

Closed jonashendrickx closed 2 months ago

jonashendrickx commented 2 months ago

Description

We do not need to override the sender in the SMTP configuration, as this is being done globally in the AggregateMailProvider.

Shape

Screenshots

Checklist

I did the following to ensure that my changes were tested thoroughly:

I did the following to ensure that my changes do not introduce security vulnerabilities:

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 35.15%. Comparing base (8697acd) to head (7c2eb6a). Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/Common/Services/Mail/Smtp/SmtpMailProvider.cs 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #705 +/- ## ======================================= Coverage 35.15% 35.15% ======================================= Files 574 574 Lines 31157 31155 -2 Branches 929 928 -1 ======================================= Hits 10952 10952 + Misses 20060 20058 -2 Partials 145 145 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.