search

bitwarden / passwordless-server

Bitwarden Passwordless.dev infrastructure/backend (API, database, Docker, etc).
https://bitwarden.com/
Other
86 stars 28 forks source link

E-Mail settings for self-hosting #712

Closed ellwoodb closed 2 months ago

ellwoodb commented 2 months ago

In a recent commit, it seems the ability to change the mailing settings via environment variables for the docker container when self hosting were removed. I was just trying to run the container (tried both, building from source and the image on docker hub) and it doesn't take the mail settings, so it logs all mails to mails.md. Is there a way to bring this feature back for those of us self hosting this?

ellwoodb commented 2 months ago

The commit was the merge of pr #707

jonashendrickx commented 2 months ago

Hi @ellwoodb , check the documentation now.

It should only take very little time to update your configuration.

I believe you may be updating using the latest tag, instead of stable. Consider sticking to stable. The latest tag could contain images that are still in QA, I hadn't published the documentation yet.

ellwoodb commented 2 months ago

Hey @jonashendrickx, thank you very much! With the new variables it‘s working nicely. I‘ll close this issue now.

Yes, I was using the latest tag and now switched to stable thanks for clarifying.

Maybe, if you have time you could update the settings.env in the self-host directory to reflect the changes. I could also do that myself with a pr if that‘s allowed?

jonashendrickx commented 2 months ago

Hey @jonashendrickx, thank you very much! With the new variables it‘s working nicely. I‘ll close this issue now.

Yes, I was using the latest tag and now switched to stable thanks for clarifying.

Maybe, if you have time you could update the settings.env in the self-host directory to reflect the changes. I could also do that myself with a pr if that‘s allowed?

There's no need! Thank you!

I've opened #724 to prevent this from happening again in the future. If I pull a docker image with the latest tag, I would assume it sort of to be production ready.

I've also clarified that this is a breaking change in the release notes.

Feel free to always make a PR. We're always open!