Closed Tyrrrz closed 2 months ago
Attention: Patch coverage is 80.00000%
with 3 lines
in your changes missing coverage. Please review.
Project coverage is 35.12%. Comparing base (
5bcf203
) to head (b106d59
). Report is 15 commits behind head on main.
Files with missing lines | Patch % | Lines |
---|---|---|
src/Common/Services/Mail/MailBootstrap.cs | 33.33% | 2 Missing :warning: |
src/Common/Services/Mail/AggregateMailProvider.cs | 90.90% | 0 Missing and 1 partial :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
705 changed the behavior in regard to how the mail providers are configured:
FileMailProvider
is used.The issue is that, in certain scenarios, the application may not be able to write data to the file system and thus may not use the
FileMailProvider
, making it a poor default choice. This happens, for example, when running in Docker, where the application is executed under an under-privileged user account for security reasons:Additionally, there does not appear to be a way to set the
NoopMailProvider
through configuration as it's only defined in tests.This PR reverts some of the user-facing behavior changes introduced in #705 and makes it so that no emails are sent when the configuration does not specify any mail provider.