bitwarden / passwordless-server

Bitwarden Passwordless.dev infrastructure/backend (API, database, Docker, etc).
https://bitwarden.com/
Other
86 stars 28 forks source link

PAS-568 | [Regression] Normalize times to local time throughout app #717

Closed jonashendrickx closed 2 months ago

jonashendrickx commented 2 months ago

Ticket

Description

Was previously rendering:

<time id="45115c76-b90b-4c56-95a4-47dbac12ef83" datetime="2024-09-01T09:15:56.176">9/1/2024, 9:15:56 AM</time>
<script nonce="">
    document.getElementById("45115c76-b90b-4c56-95a4-47dbac12ef83").innerText = new Date("2024-09-01T09:15:56.176").toLocaleString();
</script>

But should be:

<time id="45115c76-b90b-4c56-95a4-47dbac12ef83" datetime="2024-09-01T09:15:56.176Z">9/1/2024, 11:15:56 AM</time>
<script nonce="">
    document.getElementById("45115c76-b90b-4c56-95a4-47dbac12ef83").innerText = new Date("2024-09-01T09:15:56.176Z").toLocaleString();
</script>

Shape

Screenshots

Checklist

I did the following to ensure that my changes were tested thoroughly:

I did the following to ensure that my changes do not introduce security vulnerabilities:

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 35.15%. Comparing base (adf1dc2) to head (1a05d6b). Report is 5 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #717 +/- ## ======================================= Coverage 35.14% 35.15% ======================================= Files 574 573 -1 Lines 31176 31174 -2 Branches 931 931 ======================================= + Hits 10958 10960 +2 + Misses 20072 20068 -4 Partials 146 146 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.