bitwarden / passwordless-server

Bitwarden Passwordless.dev infrastructure/backend (API, database, Docker, etc).
https://bitwarden.com/
Other
86 stars 28 forks source link

PAS-452 | Vendor specific channel implementations #729

Closed jonashendrickx closed 2 months ago

jonashendrickx commented 2 months ago

Ticket

Description

Vendor specific channel implementations, so we can for example resort to using configuration sets with AWS Simple E-mail Service.

Shape

Screenshots

Checklist

I did the following to ensure that my changes were tested thoroughly:

I did the following to ensure that my changes do not introduce security vulnerabilities:

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 28.68217% with 92 lines in your changes missing coverage. Please review.

Project coverage is 35.15%. Comparing base (bc12fd4) to head (34a2cfb). Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/Common/Services/Mail/MailBootstrap.cs 44.61% 36 Missing :warning:
...ommon/Services/Mail/Aws/AwsEmailChannelStrategy.cs 0.00% 16 Missing :warning:
...mon/Services/Mail/File/FileEmailChannelStrategy.cs 0.00% 9 Missing :warning:
...ices/Mail/SendGrid/SendGridEmailChannelStrategy.cs 0.00% 9 Missing :warning:
...mon/Services/Mail/Smtp/SmtpEmailChannelStrategy.cs 0.00% 9 Missing :warning:
src/Common/Services/Mail/File/FileMailProvider.cs 0.00% 6 Missing :warning:
src/Common/Services/Mail/Aws/AwsMailProvider.cs 0.00% 2 Missing :warning:
...mon/Services/Mail/SendGrid/SendGridMailProvider.cs 0.00% 2 Missing :warning:
src/Common/Services/Mail/Smtp/SmtpMailProvider.cs 0.00% 2 Missing :warning:
...mmon/Services/Mail/Smtp/SmtpMailProviderOptions.cs 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #729 +/- ## ======================================= Coverage 35.15% 35.15% ======================================= Files 573 579 +6 Lines 31174 31252 +78 Branches 931 949 +18 ======================================= + Hits 10960 10988 +28 - Misses 20068 20119 +51 + Partials 146 145 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.