search

bitwarden / passwordless-server

Bitwarden Passwordless.dev infrastructure/backend (API, database, Docker, etc).
https://bitwarden.com/
Other
86 stars 28 forks source link

#731 | TimeToLive is not an obsolete property #738

Closed jonashendrickx closed 1 month ago

jonashendrickx commented 2 months ago

Ticket

Description

This is not an obsolete property as it's actually being used. This will incorrectly hide it from our Open API documentation.

Shape

Screenshots

Checklist

I did the following to ensure that my changes were tested thoroughly:

I did the following to ensure that my changes do not introduce security vulnerabilities:

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 35.15%. Comparing base (a5d4776) to head (ff24d6f). Report is 3 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #738 +/- ## ======================================= Coverage 35.15% 35.15% ======================================= Files 579 579 Lines 31252 31252 Branches 949 949 ======================================= Hits 10988 10988 Misses 20119 20119 Partials 145 145 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.