search

bitwarden / sdk-internal

Bitwarden internal SDK
Other
57 stars 5 forks source link

No Git tag associated with released versions #12

Open amarshall opened 3 weeks ago

amarshall commented 3 weeks ago

Hi, this repo has associated versions in the NPM registry, but none here (and the package.json file has 0.0.0). This makes determining the source code associated with a registry release more difficult than it perhaps should be (though it can potentially be gleaned from the release workflow, this is not as trivial as just referencing a Git tag.

Hinton commented 2 weeks ago

Hi @amarshall,

We partially solved this with https://github.com/bitwarden/sdk-internal/pull/17 which includes the build id in the version number. This should allow easy mapping by getting the appropriate run in https://github.com/bitwarden/sdk-internal/actions/workflows/publish-wasm-internal.yml and checking the git hash. Is this satisfactory?

amarshall commented 1 week ago

GitHub Actions logs are only retained for up to 90 days (see docs), so it only works for a limited period of time.

brjsp commented 1 week ago

@amarshall Thanks for alerting me to this. I've manually archived the existing versions at https://github.com/brjsp/sdk-internal/tags

(I'm not affiliated with Bitwarden but i maintain the package in openSUSE.)

Hinton commented 1 week ago

Hmm, would including a VERSION file on npm, containing the git hash work?