bitwarden / self-host

Bitwarden's self-hosted release repository
GNU General Public License v3.0
316 stars 55 forks source link

Changing the self-host workflow s3 bucket name to use a secret and not use the bucket name. #163

Closed joshuabjordan closed 9 months ago

joshuabjordan commented 9 months ago

This is part of our effort to move the s3 buckets that are in Dev/Test to the Prod AWS accounts. This PR removes the bucket name for Self-Host and replaces it with a secret to match the setup for the client's workflow. Our main goal for this is to move production data to production accounts.

With this change, the new bucket name is now held in the key vault in Azure, with a secret named aws-selfhost-version-bucket-name, which contains the new bucket name for the self-host version artifacts.

This will also allow us to not have to make code changes if bucket names do change; we will just be able to change the secret.

Let me know if there are any questions. Or any other places that will have to be updated along with this. Since the client's workflows use a secret in the key vault, once this is pushed through, I will update that secret with the new name.

bitwarden-bot commented 9 months ago

Logo Checkmarx One – Scan Summary & Details4dab3cb0-3e45-445c-980a-f471feab147b

No New Or Fixed Issues Found