Closed mzieniukbw closed 4 months ago
https://bitwarden.atlassian.net/browse/SM-1227
Improve error messages on failures.
action.yml
base_url
required: false
src/main.ts
access_token
BitwardenClient.loginWithAccessToken
src/parser.ts
:+1:
:memo:
:information_source:
:question:
:thinking:
:thought_balloon:
:art:
:x:
:warning:
:seedling:
:recycle:
:pick:
Checkmarx One â Scan Summary & Details â 8a408a53-0c96-42f7-8f45-7cb499f56180
đī¸ Tracking
https://bitwarden.atlassian.net/browse/SM-1227
đ Objective
Improve error messages on failures.
Changes:
action.yml
: Added default value tobase_url
, since the docs specifies that allrequired: false
inputs needs a default value.src/main.ts
:access_token
input is required - consistency withaction.yml
BitwardenClient.loginWithAccessToken
response into the error handling.src/parser.ts
:â° Reminders before review
đĻŽ Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or âšī¸ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or đ (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or â ī¸ (:warning:
) for more significant problems or concerns needing attention:seedling:
) or âģī¸ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes