[euvr] [fix] Truncate long filters - Githubissues

bitwarden / web

The website vault (vault.bitwarden.com).

https://vault.bitwarden.com

Other

2.58k stars 405 forks source link

[euvr] [fix] Truncate long filters #1639

Closed addisonbeck closed 2 years ago

addisonbeck commented 2 years ago

Type of change

[x] Bug fix
[ ] New feature development
[ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
[ ] Build/deploy pipeline (DevOps)
[ ] Other

Objective

Long filter items wrap, when they should truncate.

Code changes

Add typical ellipsis-cutoff css to link buttons

Screenshots

Screen Shot 2022-05-04 at 2 25 03 PM

Before you submit

[x] I have checked for linting errors (npm run lint) (required)
[ ] This change requires a documentation update (notify the documentation team)
[ ] This change has particular deployment requirements (notify the DevOps team)

eliykat commented 2 years ago

Looks like changing the base branch threw out the snyk check. I'm not sure we can re-run it from Github, you may need to ask someone with access, or just push another commit to get it going again. (or just merge anyway, it'll run on the feature branch)