[fix] Various Trash filter bugs from EUVR - Githubissues

bitwarden / web

The website vault (vault.bitwarden.com).

https://vault.bitwarden.com

Other

2.58k stars 405 forks source link

[fix] Various Trash filter bugs from EUVR #1681

Closed addisonbeck closed 2 years ago

addisonbeck commented 2 years ago

https://bitwarden.atlassian.net/jira/software/projects/SG/boards/34?selectedIssue=SG-290 https://bitwarden.atlassian.net/jira/software/projects/SG/boards/34?selectedIssue=SG-291 https://bitwarden.atlassian.net/jira/software/projects/SG/boards/34?selectedIssue=SG-292

This will be cherry-picked to rc

Type of change

[x] Bug fix
[ ] New feature development
[ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
[ ] Build/deploy pipeline (DevOps)
[ ] Other

Objective

There are a few bugs from the EUVR initiative that relate to the trash filter.

The "Add Item" button is still shown, it should not be
The bulk actions for the trash filter are specific, and are not being honored
The callout re: the thirty day delete job is missing

Code changes

This was a pretty simple fix, we changed the name and style of a condition but did not update the template.

Screenshots

Screen Shot 2022-05-13 at 2 09 22 PM

Before you submit

[x] I have checked for linting errors (npm run lint) (required)
[ ] This change requires a documentation update (notify the documentation team)
[ ] This change has particular deployment requirements (notify the DevOps team)