bitwarden / web

The website vault (vault.bitwarden.com).
https://vault.bitwarden.com
Other
2.58k stars 405 forks source link

Allow all hosts for dev environment #1685

Closed MGibson1 closed 2 years ago

MGibson1 commented 2 years ago

This is needed to enable testing of hCaptcha through a host proxy.

Type of change

Objective

hCaptcha does not allow execution from localhost (https://docs.hcaptcha.com/#local-development), to remediate, the suggested solution is to make up a non-localhost uri and specify it as a known host on your system. That way we get around these rules. Unfortunately, we now hit incorrect host header issues with our webpack server.

The solution to this new problem is to allow all hosts headers as done here. Given that this is for the development configuration, there should be no risk

Before you submit

MGibson1 commented 2 years ago

Documentation updates and local.json configs are more appropriate. I will add an hCaptcha testing page once our public documentation is editable again