[SG-16] Fix various small bugs - Githubissues

bitwarden / web

The website vault (vault.bitwarden.com).

https://vault.bitwarden.com

Other

2.58k stars 405 forks source link

[SG-16] Fix various small bugs #1686

Closed differsthecat closed 2 years ago

differsthecat commented 2 years ago

Type of change

[x] Bug fix
[ ] New feature development
[ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
[ ] Build/deploy pipeline (DevOps)
[ ] Other

Objective

This will be cherry picked to rc

SG-278 Show folders if items from that vault (org) are present SG-328 No Folder shows all items SG-299 No toast message appears stating user is the only owner when attempting to leave using the 3 dot menu

Code changes

src/app/modules/vault-filter/components/folder-filter.component.html: Do not hide folders if an org is selected
src/app/modules/vault/modules/individual-vault/individual-vault.component.ts: Fix filter condition for no folder being selected
src/app/modules/vault-filter/components/organization-options.component.ts: Add error toast if there are exceptions performing organzation options actions (like leavin an org)

Screenshots

https://user-images.githubusercontent.com/8926729/168646681-fdd99944-4607-4743-9107-171920f4d5a6.mov

Before you submit

[x] I have checked for linting errors (npm run lint) (required)
[ ] This change requires a documentation update (notify the documentation team)
[ ] This change has particular deployment requirements (notify the DevOps team)