[SG-344] Fix add item not using correct type - Githubissues

bitwarden / web

The website vault (vault.bitwarden.com).

https://vault.bitwarden.com

Other

2.58k stars 405 forks source link

[SG-344] Fix add item not using correct type #1701

Closed differsthecat closed 2 years ago

differsthecat commented 2 years ago

Type of change

[x] Bug fix
[ ] New feature development
[ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
[ ] Build/deploy pipeline (DevOps)
[ ] Other

Objective

Fix Add item modal not defaulting to the correct item type based on active filter selection

Code changes

src/app/modules/vault/modules/individual-vault/individual-vault.component.ts: Use activeFilter type and remove type variable that is no longer needed because the type is now stored in the activeFilter object.

Screenshots

https://user-images.githubusercontent.com/8926729/169889941-0ed3f14d-385a-4074-be48-aad9c51f0978.mov

Before you submit

[x] I have checked for linting errors (npm run lint) (required)
[ ] This change requires a documentation update (notify the documentation team)
[ ] This change has particular deployment requirements (notify the DevOps team)