[PS-326] Added missing lang attribute - Githubissues

bitwarden / web

The website vault (vault.bitwarden.com).

https://vault.bitwarden.com

Other

2.58k stars 405 forks source link

[PS-326] Added missing lang attribute #1720

Closed gbubemismith closed 2 years ago

gbubemismith commented 2 years ago

Type of change

[X] Bug fix
[ ] New feature development
[ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
[ ] Build/deploy pipeline (DevOps)
[ ] Other

Objective

The HTML element should have the correct lang attribute set. i.e. lang="en".

Code changes

src/app/app.component.ts: Used LOCALE_ID to get the current locale and set it to the html lang attribute.
src/app/modules/vault/modules/individual-vault/individual-vault.component.ts: Removed unused reference
src/app/settings/billing-sync-key.component.ts: Removed unused reference

Screenshots

Before you submit

[X] I have checked for linting errors (npm run lint) (required)
[ ] This change requires a documentation update (notify the documentation team)
[ ] This change has particular deployment requirements (notify the DevOps team)

gbubemismith commented 2 years ago

Nice! What do you think about approaching this the way the implementation details are outlined in this issue? Then we can use the same for browser and desktop, which appear to have lang="en" hardcoded

Yeah I think I should

Hinton commented 2 years ago

Closing due to move to mono repo