search

bitwarden / web

The website vault (vault.bitwarden.com).
https://vault.bitwarden.com
Other
2.57k stars 406 forks source link

TOTP from 1Password 1pif imports generate invalid codes #199

Closed takerukoushirou closed 6 years ago

takerukoushirou commented 6 years ago

I just purchased Premium membership and tested out the TOTP functionality of the client app and web browser extensions. I've previously been using 1Password and imported two accounts via the 1pif import.

The codes generated by Bitwarden for the imported accounts are rejected by the websites as being invalid. The values that were imported into Bitwarden are URIs of the form (e.g. for Microsoft): otpauth://totp/Microsoft:<username>?secret=<secret>&issuer=Microsoft

kspearrin commented 6 years ago

You need to change the stored key to just . Bitwarden does not currently support full otpauth:// schemes imported from 1Password.

takerukoushirou commented 6 years ago

@kspearrin thank you for the quick feedback. It seems a part of the message was filtered out, but I tested this with one account and replaced the URI with the <secret> part and now Bitwarden generates the same codes as 1Password does.

Are there plans for supporting the otpauth scheme eventually?

kspearrin commented 6 years ago

Yes, we eventually plan to support the URL scheme so that things like algorithm and digit legnth can also be specified. We are tracking this feature request in our forums.

takerukoushirou commented 6 years ago

@kspearrin awesome, glad to hear that. Can you point me to the feature request? I couldn't find one on https://community.bitwarden.com regarding TOTP scheme support for voting.

kspearrin commented 6 years ago

Here: https://community.bitwarden.com/t/support-sha-256-totp-keys/37

I've updated the title and description to include this request.