search

bitwarden / web

The website vault (vault.bitwarden.com).
https://vault.bitwarden.com
Other
2.58k stars 405 forks source link

Localization issues: Missing plural form #449

Closed mKoonrad closed 2 years ago

mKoonrad commented 4 years ago

There are many missing plural form in your strings. Texts like "item(s)" looks bad. In many languages translators need to have one, few (2-4 etc) and also many (>4 etc) forms.

See grammar rules: https://www.unicode.org/cldr/charts/33/supplemental/language_plural_rules.html#pl

Updated issues 20.05.2020: https://github.com/bitwarden/web/blob/da2e740e652ccf136a2cbe4fb9004ff2d908f073/src/locales/en/messages.json#L224 https://github.com/bitwarden/web/blob/da2e740e652ccf136a2cbe4fb9004ff2d908f073/src/locales/en/messages.json#L747 https://github.com/bitwarden/web/blob/da2e740e652ccf136a2cbe4fb9004ff2d908f073/src/locales/en/messages.json#L756 https://github.com/bitwarden/web/blob/da2e740e652ccf136a2cbe4fb9004ff2d908f073/src/locales/en/messages.json#L765 https://github.com/bitwarden/web/blob/da2e740e652ccf136a2cbe4fb9004ff2d908f073/src/locales/en/messages.json#L1327 https://github.com/bitwarden/web/blob/da2e740e652ccf136a2cbe4fb9004ff2d908f073/src/locales/en/messages.json#L1348 https://github.com/bitwarden/web/blob/da2e740e652ccf136a2cbe4fb9004ff2d908f073/src/locales/en/messages.json#L1372 https://github.com/bitwarden/web/blob/da2e740e652ccf136a2cbe4fb9004ff2d908f073/src/locales/en/messages.json#L1387 https://github.com/bitwarden/web/blob/da2e740e652ccf136a2cbe4fb9004ff2d908f073/src/locales/en/messages.json#L1405 https://github.com/bitwarden/web/blob/da2e740e652ccf136a2cbe4fb9004ff2d908f073/src/locales/en/messages.json#L1426 https://github.com/bitwarden/web/blob/da2e740e652ccf136a2cbe4fb9004ff2d908f073/src/locales/en/messages.json#L1472 https://github.com/bitwarden/web/blob/da2e740e652ccf136a2cbe4fb9004ff2d908f073/src/locales/en/messages.json#L3083 https://github.com/bitwarden/web/blob/da2e740e652ccf136a2cbe4fb9004ff2d908f073/src/locales/en/messages.json#L3122

bitwarden-bot commented 2 years ago

Hi @mKoonrad, We're cleaning up our repositories in preparation for a major reorganization. Issues from last year will be marked as stale and closed after two weeks. If you still need help, comment to let us know and we'll look into it. Thanks!

mKoonrad commented 2 years ago

@mKoonrad Issue still present

dwbit commented 2 years ago

Hey @mKoonrad, we are going through Crowdin issues, so please share any localization issues there.

mKoonrad commented 2 years ago

@dwbit All already reported since last 2 years

dwbit commented 2 years ago

Thanks for confirmation, if there aren't any currently open, please create a new issue for review.

mKoonrad commented 2 years ago

@dwbit Ok. I will check it in coming days.