search

bitwiseshiftleft / sjcl

Stanford Javascript Crypto Library
http://bitwiseshiftleft.github.com/sjcl/
Other
7.19k stars 987 forks source link

Why are certain modules not included in the build? #344

Open quackes opened 7 years ago

quackes commented 7 years ago

We found out, that some modules from sourcecode were not included in the main build. (e.g. sha1 and codec.arrayBuffer)

Is there a particular reason for that? This is not noted in the docs, therefore misleading.

mkropat commented 7 years ago

While looking into why codec.bytes was not included in the default build, I saw this explanation in #334:

You are correct 40 lines are not that much but I am still unsure if this is an often used feature. I mean the problem here is that modules quickly accumulate which can lead to a lot of code being added over time. So I would ask you to build your own module for now. If you get enough people behind you to include this, I will include it.

It seems reasonable that not everything be included in the default build, but I agree that it might be nice if the documentation indicated if they module you're reading up on is excluded from the default build.