search

bitwiseshiftleft / sjcl

Stanford Javascript Crypto Library
http://bitwiseshiftleft.github.com/sjcl/
Other
7.18k stars 987 forks source link

CDN versions do not make available extra modules #358

Open petero-dk opened 6 years ago

petero-dk commented 6 years ago

Looking at https://cdnjs.com/libraries/sjcl only the base class is available. However sjcl consists of additional modules (sha1, aescbc, ...) that are not available in the core version. The package scripts should be updated in order to provide these extra classes on the cdn (and check #357 to remember that the extra packages should be tested against the minified versions also)

MartinKolarik commented 6 years ago

You should be able to load all files from https://www.jsdelivr.com/package/npm/sjcl

petero-dk commented 6 years ago

Hi @MartinKolarik, I have found that, and I am doing that. But there are a couple of issues with that.

  1. As I have said in the #357 the extra files (modules) have issues with the minified sjcl.min.js file
  2. It should be trivial to add the excluded files from the build to the packages file and have them also distributed to other cdns (such as cloudflare)
  3. Personal Opinion: The way jsdeliver links to files is just not that pretty in my (otherwise amazingly nicelooking) code