search

bitwiseshiftleft / sjcl

Stanford Javascript Crypto Library
http://bitwiseshiftleft.github.com/sjcl/
Other
7.18k stars 987 forks source link

[config] ecc depends on convenience during tests? #380

Open armfazh opened 5 years ago

armfazh commented 5 years ago

Using this configuration 

./configure --without-all --with-ecc

makes that this test fails. 

Running ECC convenience test...
TypeError: sjcl.encrypt is not a function
    at sjcl.test.TestCase.doRun (evalmachine.<anonymous>:24:27)
    at evalmachine.<anonymous>:84:12
    at sjcl.test.TestCase.pauseAndThen (evalmachine.<anonymous>:4:33)
    at sjcl.test.TestCase.run (evalmachine.<anonymous>:83:10)
    at evalmachine.<anonymous>:106:29
    at evalmachine.<anonymous>:21:47
    at go (evalmachine.<anonymous>:12:9)
    at evalmachine.<anonymous>:13:50
    at evalmachine.<anonymous>:86:15
    at sjcl.test.TestCase.doRun (evalmachine.<anonymous>:77:9)
*** FAIL *** ECC convenience test: TypeError: sjcl.encrypt is not a function
  - failed 1 / 1 tests. (9 ms)

Adding convenience module makes this test succeeds.

Q: Does the ecc module depends on convenience? A: If so, there is no warning message that alerts the user. Otherwise, such a test should not run.