bitwiseworks / ffmpeg-os2

mirror of git://source.ffmpeg.org/ffmpeg.git
http://ffmpeg.org
Other
0 stars 1 forks source link

Native opus decoder is broken #4

Open dmik opened 3 years ago

dmik commented 3 years ago

Decoding of opus data using the native opus decoder is broken, a simple FFPMEG test easily reveals that:

ffmpeg -c opus -i gs-16b-2c-44100hz.opus test.wav

where the opus file is taken from here: https://dl.espressif.com/dl/audio/gs-16b-2c-44100hz.opus and the latest FFPMEG RPM (4.2.2-2) which is configured to use an external OPUS library is used.

Full story is here: https://github.com/bitwiseworks/qtwebengine-chromium-os2/issues/24#issuecomment-736854688.

dmik commented 3 years ago

According to @SilvanScherrer which checked FFmpeg changelogs, native opus support was added in version 3.3. Given that we have a nice libopus port for OS/2 (https://github.com/bitwiseworks/opus-os2) which it can be used as an external opus decoder/encoder in FFmpeg and which works well, the easiest workaround is to just disable the native opus codec in FFmpeg (I tried it locally already and it works). We will consider if it makes sense to fix this native codec at all (given our limited resources).

dmik commented 3 years ago

JFTR, I've released new RPMs with the native Opus codec disabled to exp for now. YouTube playback works like a charm. See https://github.com/bitwiseworks/rpm-specs/commit/121475a09dd586507c0b161c1da4d57b7a1b4521.