search

bitwiseworks / libc

LIBC Next (kLIBC fork)
9 stars 4 forks source link

Implemented wcsdup. Fixes issue #118 #119

Closed josch1710 closed 2 years ago

josch1710 commented 2 years ago

Implemented function wcsdup. This fixes issue #118 . I didn't implement any tests, because I don't understand the test framework.

SilvanScherrer commented 2 years ago

It seems you messed with crlf vs lf in wchar.h. Please fix it. As else the merge would break history.

josch1710 commented 2 years ago

I fixed the line endings.

dmik commented 2 years ago

Thanks for your effort however I have to decline this pull request because our wchar functions are FreeBSD based (as well as many other kLIBC parts BTW) and should come from there, not from GLibc. I imported the necessary FreeBSD source within #118.

josch1710 commented 2 years ago

It's fine. I just went with Silvan's lead. Most important thing is, that the gap is closed ;-)