search

bitwiseworks / qt5-os2

Port of Qt software development framework version 5 to OS/2
Other
18 stars 2 forks source link

Port Qt Tools module #6

Closed dmik closed 4 years ago

dmik commented 4 years ago

This module contains tools such as lrelease and lupdate which are needed for many projects. Shouldn't be difficult to port to OS/2 as it is unlikely to have a lot of platform-specific code.

dmik commented 4 years ago

The Qt Tools module contains some Q_OS_WIN (and other) defines which need to be aligned for OS/2, so we will surely need to create an OS/2 version of it.

dmik commented 4 years ago

Seems that qtdeclarative is needed for some parts of qttools. Not strictly (I mean it can build w/o it), but since we need qtdeclarative for qtwebengine anyway, I will do it first now.

dmik commented 4 years ago

I'm ready to do this one (should be quick now) but first I want to update Qt to 5.13.1 as it's already out and contains a usual bunch of fixes for the x.x.0 release.

dmik commented 4 years ago

An updated tree of Qt Tools (5.13.1) is successfully built with a few OS/2 fixes applied. Now it needs some testing.

dmik commented 4 years ago

Running tests, got one failure (out of many tests) so far:

QDEBUG : tst_lupdate::good(proparsing2) [11439-1:23:05:05.572] tst_lupdate::good:236: Checking...
FAIL!  : tst_lupdate::good(proparsing2) Result for ~/Network/novator_D/Coding/qt5/qt5/qttools/tests/auto/linguist/lupdate/testdata/good/proparsing2/project.ts.result does not meet expectations:
        <translation type="unfinished"></translation>
    </message>
    <message>
<<<<<<< got
        <location filename="b" line="31"/>
        <source>b</source>
=========
        <location filename="a.cpp" line="31"/>
        <source>a.cpp</source>
        <translation type="unfinished"></translation>
    </message>
    <message>
        <location filename="b" line="31"/>
...
>>>>>>> expected
        <translation type="unfinished"></translation>
    </message>
    <message>

   Loc: [~/Network/novator_D/Coding/qt5/qt5/qttools/tests/auto/linguist/lupdate/tst_lupdate.cpp(203)]

Need to seed what's this.

dmik commented 4 years ago

With the above, all Qt Tools auto tests succeed (except the qdoc ones but that's because we don't build qdoc as it needs libclang which we don't have (yet)).

Note also that there are some minor failures with cmake tests (some compiler flags missing) but I'm leaving it out for now — not very important.