search

bitwiseworks / qtwebengine-chromium-os2

Port of Chromium and related tools to OS/2
9 stars 2 forks source link

gn: Run unit tests #1

Closed dmik closed 4 years ago

dmik commented 4 years ago

This is a continuation of https://github.com/bitwiseworks/qtwebengine-os2/issues/3.

the GN tool provides unit tests which we should run to make sure all works as designed on OS/2. It's postponed for now as doesn't look too critical.

dmik commented 4 years ago

Seems that I have to complete this task now because of https://github.com/bitwiseworks/qtwebengine-os2/issues/1#issuecomment-582593147.

dmik commented 4 years ago

I've fixed process execution code in GN so that all ExecProcessTest tests pass now (it was actually just a regular pipe->socketpair change). But this doesn't fix the above problem when building Chromium. Now I have a guess that our LIBCfork used in GN to execute sub-tasks is not thread safe and this is what makes it crash: Chromium is trying to start several processes at once using fork. I will have to replace it with LIBCx spawn2 extension that I specifically made thread-safe and see if it helps.

dmik commented 4 years ago

With the above commits all of 492 GN tests run smoothly on OS/2.

I will leave it open though till I fix the sub-task execution problem.