search

bitworking / react-scrollmagic

React components for ScrollMagic
https://bitworking.github.io/react-scrollmagic/
372 stars 64 forks source link

ScrollMagic dependency #16

Closed antoinerousseau closed 4 years ago

antoinerousseau commented 5 years ago

Why is ScrollMagic copied in lib/scrollmagic.js instead of being imported as a npm dependency? https://www.npmjs.com/package/scrollmagic I can open a PR if you are interested.

bitworking commented 5 years ago

Because the npm package doesn't work for SSR.

Read the discussion: https://github.com/bitworking/react-scrollmagic/issues/1

antoinerousseau commented 5 years ago

I see! I was about to suggest to upgrade it to the newest version but the diff looks heavy... https://github.com/janpaepke/ScrollMagic/compare/v2.0.5...8e29c43556d59e96c1ff30aece0214073a5bc66f