Caml API functions returning unit should not return void

bitwuzla / ocaml-bitwuzla

Bitwuzla SMT solver repackaged for convenient use in opam.

MIT License

9 stars 3 forks source link

Caml API functions returning unit should not return void #4

Closed smuenzel closed 12 months ago

smuenzel commented 1 year ago

extern "C" functions that are called from ocaml should return Val_unit, rather than void. I'm not sure how much of a problem this is, but I noticed some crashes on cleaning the minor heap when examining https://github.com/bitwuzla/ocaml-bitwuzla/issues/3, and this could be one of the causes.