search

bitzesty / devise_zxcvbn

Devise plugin to reject weak passwords using zxcvbn
MIT License
194 stars 38 forks source link

Version 2.1.2 doesn't work #24

Closed owenbendavies closed 7 years ago

owenbendavies commented 8 years ago

I recently tried to upgrade from 2.1.1 to 2.1.2, and it no longer seems to work as documented. Unfortunately I haven't had time to look into why :(

rails 4.2.7.1 devise 4.2.0

See https://github.com/obduk/cms/pull/660

owenbendavies commented 7 years ago

Having looked at the code changes in that release, I've found out that it was actually my tests that weren't working not the Gem. I was using shoulda-matchers to test validation, and because now this Gem doesn't check password strength if there are other errors, these tests weren't working.