bitzesty / devise_zxcvbn

Devise plugin to reject weak passwords using zxcvbn
MIT License
194 stars 38 forks source link

Error #43

Closed mitchell-de-jong closed 2 years ago

mitchell-de-jong commented 3 years ago

wrong number of arguments (given 3, expected 1..2)

I am getting this error on a vanilla rails 6 application with devise + devise_zxcvbn extension.

This seems to be a change from rails 6 to 6.1. https://github.com/rails/rails/issues/41270

matthewford commented 3 years ago

Thanks for raising this issue, will investigate it soon.

On Wed, 7 Jul 2021 at 09:26, mitchell-de-jong @.***> wrote:

wrong number of arguments (given 3, expected 1..2)

I am getting this error on a vanilla rails 6 application with devise + devise_zxcvbn extension.

This seems to be a change from rails 6 to 6.1. rails/rails#41270 https://github.com/rails/rails/issues/41270

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/bitzesty/devise_zxcvbn/issues/43, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAABV6XSRABZUK5BDJHDHLTWQFUFANCNFSM476FA7AQ .

-- Sent from my iPhone

-- Bit Zesty Ltd, a company incorporated in England & Wales with registered number 06883289. Our registered address is 94 White Lion Street, London, N1 9PF.

biow0lf commented 3 years ago

@mitchell-de-jong

This is already fixed in master. https://github.com/bitzesty/devise_zxcvbn/pull/40

@matthewford can we have new release with ruby 3.0 fix?