search

bitzesty / devise_zxcvbn

Devise plugin to reject weak passwords using zxcvbn
MIT License
194 stars 38 forks source link

Update required version of zxcvbn to 0.1.9 #45

Closed formigarafa closed 1 year ago

formigarafa commented 1 year ago

Results produced are still compatible with dropbox/zxcvbn.js 4.4.2 but this one solves an issue with performance that could cause considerable impacts.

This version makes the algorithm to work with performance linear O(n) in relation to size of passwords, before this change it could be polynomial O(n^c).

There are more details on zxcvbn Changelog and on issue: formigarafa/zxcvbn-rb#6 and the code changes on PR formigarafa/zxcvbn-rb#7.

matthewford commented 1 year ago

@formigarafa thanks for this!