biud436 / MV

🏰 This plugin package includes helpful features to get you on your way to create your game in RPG Maker MV.
MIT License
64 stars 51 forks source link

Doesn't properly autoscale images & reposition sprites #13

Closed Cyberavater closed 1 year ago

Cyberavater commented 4 years ago

When I widescreen games using RS_ScreenManager everything works except the images don't rescale properly. Screenshot (91) Screenshot (92)

biud436 commented 4 years ago

Thank you for your feedback. I will add it that you said.

Cyberavater commented 4 years ago

It'd be nice if you could make this plugin to stretch the image to all screen as it does with the game. Screenshot (103) It'd be great if it could stretch this image and cover up the right side. BTW, thanks for working on this I really appreciate it.

biud436 commented 4 years ago
My Game Resolution : 1280 x 720
Real Image Size : 816 x 624
Converted Image Size : 1280 x 720 (worked fine)

In my case, it was tested and worked well in the above environment. However, The image magnification depends on resolution and image size and original image scale and I'm not sure in case of the other size of image.

Cyberavater commented 4 years ago

Can you make it detect the device's resolution automatically? And make it convert the image in that ratio?

biud436 commented 4 years ago

In fact ... I recommend you trying to change the scale of image using Graphics tool such as Photoshop or the GIMP.

Cyberavater commented 4 years ago

I know I can do that, but the problem will occur when a different user will play the game on devices of different resolutions. Can you make a feature for that kind of situation? So that it can automatically convert images according to its need?

biud436 commented 4 years ago

You should resize the graphic to match the game resolution you set. The size of the graphic is set regardless of the device resolution.

Cyberavater commented 4 years ago

Ah, Ok. Thanks, I'll try that and see how it goes.

Cyberavater commented 4 years ago

M̷a̷y̷b̷e̷ ̷I̷'̷m̷ ̷f̷a̷i̷l̷i̷n̷g̷ ̷t̷o̷ ̷e̷x̷p̷l̷a̷i̷n̷ ̷p̷r̷o̷p̷e̷r̷l̷y̷;̷ ̷t̷h̷i̷s̷ ̷p̷l̷u̷g̷i̷n̷ ̷o̷n̷l̷y̷ ̷r̷e̷s̷i̷z̷e̷s̷ ̷i̷m̷a̷g̷e̷s̷ ̷o̷f̷ ̷t̷h̷e̷ ̷'̷t̷i̷t̷l̷e̷s̷1̷'̷ ̷f̷o̷l̷d̷e̷r̷.̷ ̷I̷t̷'̷d̷ ̷b̷e̷ ̷r̷e̷a̷l̷l̷y̷ ̷n̷i̷c̷e̷ ̷i̷f̷ ̷i̷t̷ ̷c̷o̷u̷l̷d̷ ̷r̷e̷s̷i̷z̷e̷ ̷i̷m̷a̷g̷e̷s̷ ̷o̷f̷ ̷t̷h̷e̷ ̷'̷p̷i̷c̷t̷u̷r̷e̷s̷'̷ ̷f̷o̷l̷d̷e̷r̷ ̷t̷o̷o̷.̷ ̷W̷h̷i̷l̷e̷ ̷s̷h̷o̷w̷i̷n̷g̷ ̷i̷m̷a̷g̷e̷s̷ ̷f̷r̷o̷m̷ ̷t̷h̷e̷ ̷'̷p̷i̷c̷t̷u̷r̷e̷'̷ ̷f̷o̷l̷d̷e̷r̷ ̷t̷h̷e̷r̷e̷ ̷r̷e̷m̷a̷i̷n̷ ̷b̷l̷a̷c̷k̷ ̷b̷o̷r̷d̷e̷r̷s̷ ̷o̷n̷ ̷t̷h̷e̷ ̷r̷i̷g̷h̷t̷ ̷s̷i̷d̷e̷.̷ ̷O̷r̷ ̷ it just scales the character so much that it looks weird, also there is an issue of spites repositioning which is tackled here; https://www.youtube.com/watch?v=Vyf10-LFtjQ

biud436 commented 4 years ago

I'll check that.

biud436 commented 4 years ago

There was no problem. Please tell me how I can reproduce the bug.

https://youtu.be/2ew8CWSnKPA?t=592

The above test video shows no problem with the picture.

Cyberavater commented 4 years ago

It works fine for most games but it doesn't work well for all games. Should I send you a link to a game to test? [N.B. it's NSFW] Do you have other contacts than GitHub? (ie. Discord or any personal account?) P.S. I have also updated the issue here .

biud436 commented 4 years ago

I've added a new addon plugin called https://github.com/biud436/MV/blob/master/Windows/Resolutions/RS_ForceResize.js

biud436 commented 4 years ago

I checked the game you sent me by mail. I confirmed that you didn't setup my plugin in the Plugin Manager.

Follow these steps:

  1. Download a plugin named 'RS_ScreenManager.js' again and place it in your <Game Folder>/www/js/plugins folder.
  2. Open the directory and Move the <Game Folder>/www folder
  3. Create a file called Game.rpgproject that has a text called 'RPGMV 1.6.2' in the www folder.
  4. Execute the file called Game.rpgproject if your computer is installed RPG Maker MV already.
  5. Open the Plugin Manager and then add a plugin and then modifying plugin parameters, as follows.

image

Basically, this plugin is for game developers, not game players.

Cyberavater commented 4 years ago

Well, I know how to use that, and I purposefully sent you the copy where 'RS_ScreenManager.js' wasn't installed. Because when I enable 'Scaled Picture-true' option

Screenshot (141)

I get this;

Screenshot (140)

That's why I sent the copy where the plugin wasn't installed so that you can install it and reproduce and check the issue yourself. [Don't skip the story while checking the game, you'll find some bugs there as well (See the difference with and without the plugin, you'll see that the characters/actors are scaled poorly). After the story, you'll see the 'TypeError' mentioned above.]

P.S. Thank you so much for working on this!

biud436 commented 4 years ago

In fact, I've fixed that issue during the game and updated the plugin.

Cyberavater commented 4 years ago

I know you've fixed it, as it worked with other games not working for this particular game. But have you tried the steps I mentioned to reproduce the Issue?

biud436 commented 4 years ago

Fixed bugs that you said to 54f45d6164f69e6af5ea83945482d06f87fdc1d2

image

Please check that.

Cyberavater commented 4 years ago

Thanks, you fixed the issue that I mentioned!

Though there is another issue that needs to be fixed. Please add a feature that would automatically scale the background and reposition sprites according to the resolution during battle.

Before; Screenshot (151)

After: Screenshot (150)

You can see that during battle it's not scaled accordingly.

biud436 commented 4 years ago

Okay.... I got it.

image

I've resolved that issue. In case of the position of actor sprite, I didn't test some impacts that can conflict with the plugin named YEP_BattleEngineCore. So it must be used only in the vanilla mode.

Cyberavater commented 4 years ago

Nice! Thank you, again. But I still see a reposition/rescale problem, though it's not noticeable in your image.

Before; Screenshot (154)

After; Screenshot (152)

As you can see the actor was repositioned inaccurately or after rescaling the 'battlefield background' the loss of some dark bottom portion of it caused it. In your case, the background was supposed to match the resolution but not all should be like that since everybody doesn't use transparent BattleBar. Rather, for such cases (and all cases), it would be wise to scale the battlefield background accordingly, i.e. if the game resolution width was scaled x1.2 and hight was scaled x1.1; Rather matching the 'battlefield background' resolution with it, it would be wise to rescale the 'battlefield background' width x1.2 and hight x1.1 newly.

I hope, I was able to make it understandable. Thanks!

Cyberavater commented 4 years ago

I updated the issue; https://github.com/biud436/MV/issues/13#issuecomment-572623687

biud436 commented 4 years ago

6f073a9c9ff53b922cac4c8c218b6ab9e55a72d8 I have changed width and height values of two battle background images to fit on the screen, not scale value.

But the bottom part of the image seems a bit weird, due to image size down. so there is a margin value is to 32 in the vanilla mode. the image will be changed a bit weird after changed its value is to 0.

Cyberavater commented 4 years ago

After the last update, I can fully see the battleground even the bottom part of it, thanks! But a little positioning issue still exits!

Screenshot (155)

As you can see an actor is flying in the sky!

I'm not sure which reposition method you used, but I think I can suggest one that can fix this issue.

I hope it's feasible, thanks!

Cyberavater commented 4 years ago

I can send you the game link if you need it to test and reproduce the issue.

biud436 commented 4 years ago

What the mean of 'old'?

Cyberavater commented 4 years ago

'old' as the one which was set before using the plugin. Tho, I don't know about code since I'm not a programmer, that's why I asked if it was feasible.

biud436 commented 4 years ago

The problem is that the size of the battler image didn't change.

In fact, it doesn't consider width and height values of bitmap in the vanilla mode and all values are written directly in the source file.

The default settings are aiming in 816 x 624 resolution(I don't like this so I changed the value as absolute ratio).

so I've converted values to fit a calculated ratio.

However, that values didn't consider the width and height values of default bitmap.

Cyberavater commented 4 years ago

So, in other words, there is nothing to do, right? Or, should I send a game sample that might help you?

Cyberavater commented 4 years ago

I've sent a sample game to help you via Gmail.

Cyberavater commented 4 years ago

Screenshot (1)

Can you reprogram this script so that it can reposition battlers following the resolution? (Rather than giving it a direct value, aiming at a specific resolution the reposition value should be given by the plugin accordingly calculated for the resolution automatically )

The problem is that the size of the battler image didn't change.

Can't you reprogram the script to do that as well?

Thanks for working on this.

biud436 commented 4 years ago

I think you have to set all battlers' position manually.

Cyberavater commented 4 years ago

But there is a problem with that, the end-user might not be a game developer working with RPG Maker MV. So if they use this plugin and change their resolution, the battlers' position will be messed up.

Can you please check this plugin? here; https://www.youtube.com/watch?v=Vyf10-LFtjQ They seem somehow managed to make the reposition automatic. [Check Spites Reposition ] Thanks!

Cyberavater commented 4 years ago

I get this; Screenshot (34)

Cyberavater commented 4 years ago

It seems you removed the 'Spites Reposition' & 'ScreenManager' feature. Any plan to reintroduce them? These features would really be great if you could make those work perfectly, thanks!

Screenshot (1)

biud436 commented 4 years ago

I've been updating plugins steadily, however I've known that most people are not using my resolution plugin. some features such as resetting scale and position are pretty unstable so it didn't worth it until now, so I've removed temporarily in the public file. But you can still access the script of previous version in the Github.

See below link : https://github.com/biud436/MV/raw/master/Windows/Resolutions/dist/RS_ScreenManager.js

Renvaar commented 3 years ago

Cyberavater can I try your game?

Cyberavater commented 3 years ago

Cyberavater can I try your game?

Of course, but its NSFW. Still, if you wanna try it, drop your telegram ID here.