search

bivalent / DIM-to-LL-converter

Script that converts DIM wishlists to the LL format for importing / validation
5 stars 1 forks source link

Problem converting Chevy's S14 wishlish. #1

Open Deanosim opened 2 years ago

Deanosim commented 2 years ago

Trying to convert Chevy's S14 Wishlist spits out the following error,

dimwishlist:item=4281371574&perks=1840239774,106909392,247725512,4049631843#notes:Chevy's S14 Super Pog PvE Loot List (MKB/PVE). Recommended MW - Reload/Handling

dimwishlist:item=4281371574&perks=1840239774,106909392,1820235745,4049631843#notes:Chevy's S14 Super Pog PvE Loot List (MKB/PVE). Recommended MW - Reload/Handling

dimwishlist:item=4281371574&perks=1840239774,106909392,247725512,3038247973#notes:Chevy's S14 Super Pog PvE Loot List (MKB/PVE). Recommended MW - Reload/Handling

Traceback (most recent call last):
  File "convert.py", line 59, in <module>
    perkColumns[j].add(int(perkList[j]))
ValueError: invalid literal for int() with base 10: '3038247973#notes'

I took a bit of a look at the python code to see if I could fix it, but I don't know enough about python. I'm assuming it's the fact that the code is expecting a space between the end of the perks list and the #notes

bivalent commented 2 years ago

Thanks, sorry for the 8 day delay. I'll take a look!

bivalent commented 2 years ago

I took a look. It seems the format of the files changed.

It used to be: [Edit: it hasn't changed just different files have different formats]

// Fatebringer (Timelost) //notes:light.gg (PvE): S-Tier (Best). Recommended MW: Range.|tags:pve dimwishlist:item=1216319404&perks=4090651448,3142289711,3038247973,1015611457

And now it's:

dimwishlist:item=681067419&perks=1840239774,106909392,247725512,4049631843#notes:Chevy's S14 Super Pog PvE Loot List (MKB/PVE). Recommended MW - Reload/Handling

without the weapon name above each section. I will look through the rest of the files and if they are using a new format I'll update this script to read those

bivalent commented 2 years ago

Hmm....

https://raw.githubusercontent.com/48klocs/dim-wish-list-sources/master/choosy_voltron.txt

uses the formatting that this script expects.

https://48klocs.github.io/wish-list-magic-wand/fingerwave.html

"If you're looking to build your own lists, I have a tool that can help generate permutations for you - the source for it is here.

Seems his script uses the same format.

I'll drop an issue on the repo and see where the formatting mis-match comes from, as it's not standardized with the rest of the ecosystem. If it's not easily solvable by them, I'll look into a second script that handles the formatting of those other files

[edit] created issue is here: https://github.com/48klocs/dim-wish-list-sources/issues/76