bivashy / MC-Auth-with-Link

Fork of mc-auth. Added multiple ways to link
Eclipse Public License 2.0
31 stars 9 forks source link

[Bug] /login #192

Open OurLobanov opened 5 days ago

OurLobanov commented 5 days ago

Enter the server Enter incorrect passwords until you get kicked Try to enter the incorrect password again You will be kicked immediately for the incorrect password, but it should ideally give you more attempts

bivashy commented 5 days ago

Fill out the form:

**Describe the bug**
A clear and concise description of what the bug is.

**To Reproduce**
Steps to reproduce the behavior:
1. Launch '...'
2. Execute '....'
3. See error

**Expected behavior**
A clear and concise description of what you expected to happen.

**Screenshots**
If applicable, add screenshots to help explain your problem.

**Additional context**
Add any other context about the problem here.

We need more info such as:

  1. Configuration
  2. Commit version
  3. Logs (if there are any exception)
OurLobanov commented 5 days ago

image image image

OurLobanov commented 5 days ago

После выхода или кика попытки идут в минус если ввести пароль правильно я зайду в аккаунт

bivashy commented 5 days ago

This is because AuthenticationAttempListener uses AccountStateClearEvent, we need to call AccountStateClearEvent in PlayerQuitEvent too.

bivashy commented 5 days ago

This is because AuthenticationAttempListener uses AccountStateClearEvent, we need to call AccountStateClearEvent in PlayerQuitEvent too.

The main problem is: We need to somehow avoid two parallel connection, for example when 2 connection made into one account simultaneously breaking authentication steps. Probably AuthenticationStepManagement could help with that purpose.