[AM-5] Administrative CLI - Githubissues

bixlabs / authentication

A module in Go for authentication

1 stars 0 forks source link

[AM-5] Administrative CLI #40

Closed acabreragnz closed 5 years ago

acabreragnz commented 5 years ago

Description

As an administrator I should be able to create/update/delete or find users, I should also be able to reset their password through a command line utility tool.

Stories

https://bixlabs.atlassian.net/browse/AM-5

List of changes

add: user manager with CRUD operations
add: new CLI client using Cobra

Steps to Test or Reproduce

make test

Or you could play with the CLI manually

make build-admin-cli
./tmp/admincli # to see the available commands

# to create a user
./tmp/admincli create --email acabrera@bixlabs.com

# to find it
./tmp/admincli find acabrera@bixlabs.com

# play also with the other commands

Impacted Areas in Application

Authenticator
User Manager

TODO

[ ] improve short and long descriptions for all the commands
[ ] add documentation to README.md
[ ] follow the layout guidelines

todo[bot] commented 5 years ago

we should use an utility for this in the overall file

https://github.com/bixlabs/authentication/blob/a2f26f98761435665455d4470d4e96fd03981cf1/authenticator/interactors/implementation/authenticator_test.go#L76-L79

This comment was generated by todo based on a `TODO` comment in a2f26f98761435665455d4470d4e96fd03981cf1 in #40. cc @bixlabs.

todo[bot] commented 5 years ago

rename this error property

https://github.com/bixlabs/authentication/blob/a2f26f98761435665455d4470d4e96fd03981cf1/authenticator/interactors/implementation/user_manager_test.go#L39-L44

This comment was generated by todo based on a `TODO` comment in a2f26f98761435665455d4470d4e96fd03981cf1 in #40. cc @bixlabs.

todo[bot] commented 5 years ago

rename this error property

https://github.com/bixlabs/authentication/blob/a2f26f98761435665455d4470d4e96fd03981cf1/authenticator/interactors/implementation/user_manager_test.go#L49-L54

This comment was generated by todo based on a `TODO` comment in a2f26f98761435665455d4470d4e96fd03981cf1 in #40. cc @bixlabs.

todo[bot] commented 5 years ago

rename this error property

https://github.com/bixlabs/authentication/blob/a2f26f98761435665455d4470d4e96fd03981cf1/authenticator/interactors/implementation/user_manager_test.go#L100-L105

This comment was generated by todo based on a `TODO` comment in a2f26f98761435665455d4470d4e96fd03981cf1 in #40. cc @bixlabs.

todo[bot] commented 5 years ago

rename this error property

https://github.com/bixlabs/authentication/blob/a2f26f98761435665455d4470d4e96fd03981cf1/authenticator/interactors/implementation/user_manager_test.go#L121-L126

This comment was generated by todo based on a `TODO` comment in a2f26f98761435665455d4470d4e96fd03981cf1 in #40. cc @bixlabs.

todo[bot] commented 5 years ago

rename this error property

https://github.com/bixlabs/authentication/blob/a2f26f98761435665455d4470d4e96fd03981cf1/authenticator/interactors/implementation/user_manager_test.go#L163-L168

This comment was generated by todo based on a `TODO` comment in a2f26f98761435665455d4470d4e96fd03981cf1 in #40. cc @bixlabs.

todo[bot] commented 5 years ago

rename this error property

https://github.com/bixlabs/authentication/blob/a2f26f98761435665455d4470d4e96fd03981cf1/authenticator/interactors/implementation/user_manager_test.go#L199-L204

This comment was generated by todo based on a `TODO` comment in a2f26f98761435665455d4470d4e96fd03981cf1 in #40. cc @bixlabs.

todo[bot] commented 5 years ago

rename this error property

https://github.com/bixlabs/authentication/blob/a2f26f98761435665455d4470d4e96fd03981cf1/authenticator/interactors/implementation/user_manager_test.go#L217-L222

This comment was generated by todo based on a `TODO` comment in a2f26f98761435665455d4470d4e96fd03981cf1 in #40. cc @bixlabs.

todo[bot] commented 5 years ago

rename this error property

https://github.com/bixlabs/authentication/blob/a2f26f98761435665455d4470d4e96fd03981cf1/authenticator/interactors/implementation/user_manager_test.go#L227-L232

This comment was generated by todo based on a `TODO` comment in a2f26f98761435665455d4470d4e96fd03981cf1 in #40. cc @bixlabs.

todo[bot] commented 5 years ago

This variable name is not descriptive

https://github.com/bixlabs/authentication/blob/a2f26f98761435665455d4470d4e96fd03981cf1/authenticator/interactors/implementation/util/util.go#L10-L15

This comment was generated by todo based on a `TODO` comment in a2f26f98761435665455d4470d4e96fd03981cf1 in #40. cc @bixlabs.

mradzinski commented 5 years ago

I went through all this and it seems to be alright. Still, I want @jac1013 or @rkmax to review this due to the fact it's written in Go.

jac1013 commented 5 years ago

@acabreragnz I created JIRA tickets for the TODOs that you left in the description of the PR, let's merge this. Awesome stuff, thanks!