search

bixlabs / documentation

5 stars 1 forks source link

Eslint rules configuration #2

Closed ghost closed 7 years ago

ghost commented 7 years ago

The .eslintrc rules are configured incorrectly, right now it is defined like this:

{
  "extends": "airbnb",
  "comma-dangle": ["error", "never"],
}

It should be:

{
  "extends": "airbnb",
  "rules": {
    "comma-dangle": ["error", "never"]
  }
}

Otherwise the rules configuration will be ignored.

Also, I don't know about that trailing comma, should we keep it? What do you think? :)

jac1013 commented 7 years ago

Hi @evasquez26 You are right, if possible create a PR to apply the changes.

Thanks!